Bug 994 – Makefile always defining CONFIG_* for external builds

Bug 994 - Makefile always defining CONFIG_* for external builds

Summary:

Makefile always defining CONFIG_* for external builds

Status:	VERIFIED FIXED

Product:	IPW3945
Component:	Install
Version:	0.0.73
Platform:	All All

Importance:	P2 normal
Assigned To:	James Ketrenos
QA Contact:

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-04-04 16:11 by Henrik Brix Andersen
Modified:	2006-04-19 02:20 (History)

Attachments
Proposed patch (2.46 KB, patch) 2006-04-04 16:12, Henrik Brix Andersen	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Henrik Brix Andersen 2006-04-04 16:11:50

Only add the CONFIG_* definitions to CFLAGS if the corresponding Makefile
variable is set to enabled, otherwise the #ifdef checks in the C code will
always evaluate to true. Also wraps the debug module parameter in #ifdefs.

------- Comment #1 From Henrik Brix Andersen 2006-04-04 16:12:48 -------

Created an attachment (id=746) [details]
Proposed patch

------- Comment #2 From James Ketrenos 2006-04-04 17:17:41 -------

Merged for 0.0.74.

Thanks.

------- Comment #3 From Mi, Jun 2006-04-19 01:07:09 -------

Brix, can you verify this bug in 0.0.74?

------- Comment #4 From Henrik Brix Andersen 2006-04-19 02:20:48 -------

Verified with ipw3945-0.0.74.