Bug 987 – Do not set MODVERDIR when running make

Bug 987 - Do not set MODVERDIR when running make

Summary:

Do not set MODVERDIR when running make

Status:	VERIFIED NEEDSMOREDATA

Product:	IPW2200
Component:	Install
Version:	unspecified
Platform:	All All

Importance:	P2 normal
Assigned To:	Zhu Yi
QA Contact:

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-03-31 07:00 by Henrik Brix Andersen
Modified:	2006-10-07 22:59 (History)

Attachments
Proposed patch (980 bytes, patch) 2006-03-31 07:02, Henrik Brix Andersen	Details \| Diff
patch with slight change (779 bytes, patch) 2006-04-12 00:50, Zhu Yi	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Henrik Brix Andersen 2006-03-31 07:00:46

Setting MODVERDIR in the Makefile causes make to fail when the kernel compiled
against is set to output its objects to a different dir using either O= or
KBUILD_OUTPUT=

After all, setting MODVERDIR has always been a hack in order to avoid a few
harmless warnings about undefined ieee80211 symbols.

A similar change was made to ieee80211-1.1.13 in order to fix bug #984.

------- Comment #1 From Henrik Brix Andersen 2006-03-31 07:02:16 -------

Created an attachment (id=742) [details]
Proposed patch

This patch fixes part of the following downstream bug report:

  http://bugs.gentoo.org/126306

------- Comment #2 From Zhu Yi 2006-04-12 00:50:54 -------

Created an attachment (id=758) [details]
patch with slight change

I'm going to merge this patch. It leaves the IEEE80211_MODVERDIR part because
it shuts up modpost waring message. Let me know if it doesn't work with you.

------- Comment #3 From Henrik Brix Andersen 2006-04-12 01:21:46 -------

Have you tested it with KBUILD_OUTPUT set to something other than where the
kernel source is (seperate object directory)?

------- Comment #4 From Zhu Yi 2006-04-12 22:55:48 -------

(In reply to comment #3)
> Have you tested it with KBUILD_OUTPUT set to something other than where the
> kernel source is (seperate object directory)?

OK. I've tried that. Just specify the KBUILD_OUTPUT directory as KSRC. For
example make KSRC=/the/KBUILD_OUTPUT/dir

------- Comment #5 From Henrik Brix Andersen 2006-04-13 13:52:59 -------

(In reply to comment #4)
> OK. I've tried that. Just specify the KBUILD_OUTPUT directory as KSRC. For
> example make KSRC=/the/KBUILD_OUTPUT/dir

That's definately not the correct way to do it. How would the build system
determine where to find the header files then?

------- Comment #6 From Zhu Yi 2006-04-13 21:19:14 -------

(In reply to comment #5)
> That's definately not the correct way to do it. How would the build system
> determine where to find the header files then?

Shouldn't the /lib/modules/`uname -r`/build point to the KBUILD_OUTPUT directory
if the KBUILD_OUTPUT is used? /lib/modules/`uname -r`/source will point to the
real source.

------- Comment #7 From Mi, Jun 2006-09-10 19:21:27 -------

Brix,

do you have any update to this bug?

------- Comment #8 From Henrik Brix Andersen 2006-09-11 00:00:33 -------

(In reply to comment #7)
> do you have any update to this bug?

Not more than I already provided, no.

------- Comment #9 From Mi, Jun 2006-10-07 22:59:54 -------

I verify this bug here. If anyone finds this bug again, please reopen it.