Bug 976 – RTS Threshold value 2344 not supported by driver

Bug 976 - RTS Threshold value 2344 not supported by driver

Summary:

RTS Threshold value 2344 not supported by driver

Status:	VERIFIED FIXED

Product:	IPW3945
Component:	Fragmentation
Version:	0.0.66
Platform:	All All

Importance:	P1 minor
Assigned To:	James Ketrenos
QA Contact:

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-03-27 19:32 by Mi, Jun
Modified:	2006-04-25 20:14 (History)

Attachments
Set RTS handling to match 802.11 spec (2.83 KB, patch) 2006-04-05 09:01, James Ketrenos	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Mi, Jun 2006-03-27 19:32:35

Steps to Reproduce:
1.load driver
2.set rts value to greater than 2303 via iwconfig
3.check rts value through iwconfig
 
Expected Results: values less than 2347 are supported
Actual Results: values less than 2304 are supported
 
Setup:
        Traffic and test tool(s):iwconfig
        Clean System (y/n)?:y
 
Additional Info: 
        Reproducible (y/n/sometimes)? y
        Passes on Different Configuration(s)? na
        Event Log Data: (attached?)no

it does not match 802.11G spec

------- Comment #1 From Mi, Jun 2006-03-27 19:34:38 -------

The only reference to the range 1..2347 is in the dot11 MIB entries. Our 
driver does not export a MIB interface and this bug does not impact spec 
compliance.

------- Comment #2 From James Ketrenos 2006-03-28 11:29:28 -------

Fixed in 0.0.72

------- Comment #3 From zhanyuanhai 2006-04-05 01:30:37 -------

0.0.72 still not support to set rts 2344 , 1 to 2343 is available

------- Comment #4 From James Ketrenos 2006-04-05 09:01:50 -------

Created an attachment (id=748) [details]
Set RTS handling to match 802.11 spec

Please try the attached patch against 0.0.74.  This patch changes the RTS
threshold behavior as follows:

RTS threshold set to 0 will use RTS for all unicast data/mgmt packet.
RTS threshold set to > max MSDU will not use RTS for any unicast data/mgmt
packets
RTS threshold set to > 2347 or < 0 will return an error
all other values will result in RTS for unicast data/mgmt frames if the MPDU is
greater than the RTS 

max MSDU == 2304
max MPDU == 2346

Default RTS threshold is 2347 (resulting in no RTS usage)

------- Comment #5 From James Ketrenos 2006-04-06 07:38:40 -------

Setting to NEEDSMOREDATA for patch feedback.

------- Comment #6 From zhanyuanhai 2006-04-12 00:41:04 -------

I have tested on ipw3945-0.0.74 attached the patch ,
set 0 <=rts<= 2304 can be used ,
set rts>= 2304 or rts<= 2347 turns off the rts ,
set rts >= 2348 or < 0 return an error.
the result correspond with James's description.

------- Comment #7 From Wei Wang 2006-04-13 23:11:38 -------

Reopen it, and waiting for the next release to merge this patch. Then VERIFIED
can be marked.

------- Comment #8 From James Ketrenos 2006-04-17 14:07:21 -------

Merged for 1.0.1

Setting to Fixed.

------- Comment #9 From zhanyuanhai 2006-04-25 20:14:06 -------

Environment:
ipw3945-1.0.2 , ieee-1.1.13, ucode-1.13, deamon-1.7.18 kernel-2.6.15.3
%iwconfig eth1 rts $rts
RTS threshold set to 0-2304, RTS= $rts
RTS threshold set to 2305-2347 ,RTS= 0
RTS threshold set to > 2347 or < 0 ,return an error