Bug 933 - Association to hidden networks times out
: Association to hidden networks times out
Status: VERIFIED FIXED
: IPW3945
BSS
: 0.0.69
: All All
: P1 normal
Assigned To:
:
:
:
:
:
  Show dependency treegraph
 
Reported: 2006-03-03 12:20 by
Modified: 2006-04-07 01:45 (History)


Attachments
Change ASSOCIATION_TIMEOUT to 750 msecs vs. HZ/2 (1.03 KB, patch)
2006-03-03 12:22, James Ketrenos
Details | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2006-03-03 12:20:04
A user reported association timeout occurring on their system with 0.0.69.  

Their system is configured for CONFIG_HZ=250 (CONFIG_HZ_250=y).

Changing the ASSOCIATION_TIMEOUT from HZ/2 to HZ*2 resolved the problem.
------- Comment #1 From 2006-03-03 12:22:09 -------
Created an attachment (id=697) [details]
Change ASSOCIATION_TIMEOUT to 750 msecs vs. HZ/2

This patch changes the ASSOCIATION_TIMEOUT from (HZ/2) to 750 and changes its
use in ipw_associate_network() from:

queue_delayed_work(priv->workqueue, &priv->associate_timeout,
			   ASSOCIATE_TIMEOUT);

to

queue_delayed_work(priv->workqueue, &priv->associate_timeout,
			   msecs_to_jiffies(ASSOCIATE_TIMEOUT));

Pending feedback to determine if 750ms is enough time or if a longer default is
required.
------- Comment #2 From 2006-03-17 12:16:43 -------
The attached patch was merged for 0.0.71 -- this should improve the situation in
some environments, but we don't know if it will actually *fix* the problem, so
not setting to 'fixed' until we hear back if 0.0.71 has improved the situation
for users.
------- Comment #3 From 2006-03-23 07:55:14 -------
The problem is actually unrelated to HZ setting; we were doing the right thing
before re: HZ/2.  The problem is that association to hidden networks is taking a
very long time for the reporter.

I am changing summary as such from:

"Association timeout on systems where HZ != 1000"
to
"Association to hidden networks times out"

The submitter indicated via email that they had to increase the timeout from
750ms up to 2500ms in order to consistently be able to associate in their
environment.
------- Comment #4 From 2006-03-24 03:23:40 -------
Your patch works for me, I can not reproduce the association timeout with a  
timeout value of 750ms anymore. 
------- Comment #5 From 2006-03-28 12:16:54 -------
Patch was merged in 0.0.71 but didn't get in the change log -- I've added the
'fixed' line into the 0.0.72 changelog.  Marking as Fixed in 0.0.72.
------- Comment #6 From 2006-04-02 23:46:40 -------
(In reply to comment #2)
> The attached patch was merged for 0.0.71 -- this should improve the 
situation in
> some environments, but we don't know if it will actually *fix* the problem, 
so
> not setting to 'fixed' until we hear back if 0.0.71 has improved the 
situation
> for users.


I tested it with 0.0.71 ,there was no time out error after association with a 
hidden work.  



------- Comment #7 From 2006-04-05 00:43:38 -------
verify on 0.0.71
------- Comment #8 From 2006-04-07 01:45:47 -------
verified on 0.0.73