Bug 715 – netif_carrier_on not called

Bug 715 - netif_carrier_on not called

Summary:

netif_carrier_on not called

Status:	VERIFIED FIXED

Product:	IPW2100
Component:	__UNSPECIFIED__
Version:	1.1.0
Platform:	All All

Importance:	P2 minor
Assigned To:	Zhu Yi
QA Contact:

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-06-28 13:16 by Ben Osheroff
Modified:	2005-07-20 23:01 (History)

Attachments
call netif_carrier_on from ipw2100_open (439 bytes, patch) 2005-06-28 13:17, Ben Osheroff	Details \| Diff
modified version, remove unnecessary checking for netif_wake_queue (2.76 KB, patch) 2005-06-28 23:48, Zhu Yi	Details \| Diff
cleanup patch (last patch is dirty with other 2200 change) (1.75 KB, patch) 2005-06-28 23:54, Zhu Yi	Details \| Diff
Hide Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Ben Osheroff 2005-06-28 13:16:23

If the ipw2100 auto-associates before ipw2100_open() is called, then first call
to netif_carrier_on will be overridden ( netdev_open resets the carrier flag ).

This results in breaking some network monitors ( gnome-netmon-2.10 ) which rely
on this flag.

Attached patch fixes.

------- Comment #1 From Ben Osheroff 2005-06-28 13:17:21 -------

Created an attachment (id=440) [details]
call netif_carrier_on from ipw2100_open

------- Comment #2 From Zhu Yi 2005-06-28 23:48:57 -------

Created an attachment (id=441) [details]
modified version, remove unnecessary checking for netif_wake_queue

------- Comment #3 From Zhu Yi 2005-06-28 23:50:15 -------

Thanks ben for the patch. mark as fixed.

------- Comment #4 From Zhu Yi 2005-06-28 23:54:37 -------

Created an attachment (id=442) [details]
cleanup patch (last patch is dirty with other 2200 change)

------- Comment #5 From Joris Vandalon 2005-07-09 03:47:14 -------

This patch worked great for me with ipw2100-1.1.1-pre1.

Cheers,
Joris

------- Comment #6 From Yan, Yechun 2005-07-20 23:01:30 -------

Verified in 1.1.2.