Bug 680 – Allow compiling against kernel patched with Software Suspend 2.1.8.7

Bug 680 - Allow compiling against kernel patched with Software Suspend 2.1.8.7

Summary:

Allow compiling against kernel patched with Software Suspend 2.1.8.7

Status:	VERIFIED FIXED

Product:	IPW2200
Component:	Power Management
Version:	unspecified
Platform:	All All

Importance:	P2 normal
Assigned To:	Zhu Yi
QA Contact:

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-05-24 07:55 by svetljo
Modified:	2005-07-14 11:28 (History)

Attachments
compile fix (328 bytes, patch) 2005-05-24 10:38, svetljo	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From svetljo 2005-05-24 07:55:54

the attached patch checks for defenition of PF_SYNCTHREAD
not for CONFIG_SOFTWARE_SUSPEND2 
which fixes compilation when swsusp2 patches are applied
but swsusp2 is not enabled and doesn't depend on the name
of the config options thus enabling building with all 
2.1.x.x versions of swsusp2

------- Comment #1 From svetljo 2005-05-24 10:38:47 -------

Created an attachment (id=406) [details]
compile fix

------- Comment #2 From Zhu Yi 2005-05-24 23:01:28 -------

I agree this is better than current approach. But since PF_SYNCTHREAD is defined
in sched.h (not kthread.h), I wonder if it is possible for the PF_SYNCTHREAD
patch is merged to mainline or -mm, but the kthread change is not yet. We will
fail again in this case.

Will use PF_SYNCTHREAD if we cannot find a better one after bug scrub.

------- Comment #3 From svetljo 2005-05-25 03:15:00 -------

(In reply to comment #2)
> I agree this is better than current approach. But since PF_SYNCTHREAD is defined
> in sched.h (not kthread.h), I wonder if it is possible for the PF_SYNCTHREAD
> patch is merged to mainline or -mm, but the kthread change is not yet. We will
> fail again in this case.
> 
> Will use PF_SYNCTHREAD if we cannot find a better one after bug scrub.

IMHO mainline wont be a problem soon,
not sure about -mm, but i think it wont be included in -mm that soon too
and i don't see a way to check (in a ifdef way) wether the kthread patch 
is applied.

------- Comment #4 From Salwan Searty 2005-05-26 08:21:24 -------

Resolution from scrub was to use PF_SYNCTHREAD.

------- Comment #5 From Zhu Yi 2005-06-16 03:16:05 -------

patch applied, thanks!

------- Comment #6 From Salwan Searty 2005-07-14 11:28:49 -------

Verified against 1.0.5.