Bug 653 – Allow compiling against kernel patched with Software Suspend 2.1.8.7

Bug 653 - Allow compiling against kernel patched with Software Suspend 2.1.8.7

Summary:

Allow compiling against kernel patched with Software Suspend 2.1.8.7

Status:	VERIFIED FIXED

Product:	IPW2100
Component:	Power Management
Version:	1.1.0
Platform:	All All

Importance:	P2 normal
Assigned To:	Zhu Yi
QA Contact:

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-05-05 13:00 by Henrik Brix Andersen
Modified:	2005-10-09 12:20 (History)

Attachments
Patch for ipw2100-1.1.0 (1.15 KB, patch) 2005-05-05 13:01, Henrik Brix Andersen	Details \| Diff
fix for all recent swsusp2 versions (338 bytes, patch) 2005-05-24 07:52, svetljo	Details \| Diff
Hide Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Henrik Brix Andersen 2005-05-05 13:00:52

The CONFIG option changed to CONFIG_SUSPEND2 starting with Software Suspend
2.1.8.7 - this patch allows compiling against kernels patched with Software
Suspend 2.1.8.7.

------- Comment #1 From Henrik Brix Andersen 2005-05-05 13:01:40 -------

Created an attachment (id=365) [details]
Patch for ipw2100-1.1.0

------- Comment #2 From svetljo 2005-05-24 07:52:15 -------

Created an attachment (id=403) [details]
fix for all recent swsusp2 versions

the attached patch checks for defenition of PF_SYNCTHREAD
not for CONFIG_SOFTWARE_SUSPEND2 
which fixes compilation when swsusp2 patches are applied
but swsusp2 is not enabled and doesn't depend on the name
of the config options

------- Comment #3 From Henrik Brix Andersen 2005-05-24 08:01:31 -------

Where is PF_SYNCTHREAD defined? I can't find it in Software Suspend 2.1.8.9...

------- Comment #4 From Henrik Brix Andersen 2005-05-24 08:10:50 -------

From suspend2 developer Bernard Blackham on #ipw2100:

17:07:13 < bernard_> PF_SYNCTHREAD is defined in include/linux/sched.h, as part
of the new freezer mechanism that suspend2 introduced.
17:08:54 < bernard_> detecting PF_SYNCTHREAD will determine if the kernel has
been *patched* with the suspend2 freezer (which is what raises the need for the
workqueue change), and doesn't depend on it being turned on. it also means that
if the freezer gets merged into the kernel, nothing else need be worried about.

------- Comment #5 From Henrik Brix Andersen 2005-05-24 08:14:04 -------

A similar patch should be applied to ipw2200-1.0.5.

------- Comment #6 From Zhu Yi 2005-06-16 03:18:00 -------

patch applied, thanks!

------- Comment #7 From Yan, Yechun 2005-07-20 23:48:42 -------

This patch isn't in 1.1.2. Please add in.

Thanks.

------- Comment #8 From Henrik Brix Andersen 2005-07-20 23:53:05 -------

ipw2100.c from ipw2100-1.1.2 contains the following lines, which allows
compiling against all recent software suspend 2 versions:

#ifdef PF_SYNCTHREAD
        priv->workqueue = create_workqueue(DRV_NAME, 0);
#else
        priv->workqueue = create_workqueue(DRV_NAME);
#endif

------- Comment #9 From Yan, Yechun 2005-07-21 00:02:48 -------

Thanks for your reminder, brix.

Mark as verified.