Bug 624 - duplicate address detected
: duplicate address detected
Status: VERIFIED FIXED
: IPW2200
__UNSPECIFIED__
: 1.0.2
: ACER All
: P2 normal
Assigned To:
:
:
:
:
:
  Show dependency treegraph
 
Reported: 2005-04-05 03:13 by
Modified: 2005-10-09 10:18 (History)


Attachments
this patch fixes it for me(tm) (1.55 KB, patch)
2005-04-05 04:06, Bernard Blackham
Details | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2005-04-05 03:13:01
This bug has been reported several times, most recently in Bug 508, which claims
it is fixed in 1.0.2. However, I'm running 1.0.2 here and I'm getting the same
problem.

The patches that were submitted on those bugs differ from what is the existing
code in is_network_packet(). They seem to have variants on addr1/addr3 and
whether or not memcmp(...) is returned, or !memcmp(...) is returned. Which
address should be correct?

I might get some time to dabble on the weekend to see what works.
------- Comment #1 From 2005-04-05 04:06:07 -------
Created an attachment (id=330) [details]
this patch fixes it for me(tm)

Seems that the broadcast/multicast case was passing the relevant packets
through. This patch reorders the code, and discards on src address != self.
------- Comment #2 From 2005-04-05 15:21:29 -------
Merged for 1.0.3

Thanks,
James
------- Comment #3 From 2005-04-11 06:08:18 -------
The patch seems not applied correctly in ipw2200 1.0.3.
Line 6326 in ipw2200 1.0.3 should have a "break" sentence.



------- Comment #4 From 2005-04-11 19:08:02 -------
The patch is changed a little bit to merge into 1.0.3, the return 
line "return !memcmp(header->addr1, priv->net_dev->dev_addr, ETH_ALEN);
" is not deleted, so the "break" is not needed :)

Mark the bug as verified. 
------- Comment #5 From 2005-06-22 02:59:39 -------
I always have this problem with drivers :
- 1.0.0
- 1.0.1
- 1.0.3
- 1.0.4 (with firmware 2.3, of course)

my AP is an SMC2671W (only a 802.11b AP) that I have upgraded to the last firmware.

Symptoms :
1) duplicate Packets, packet loss, fluctuating ping times
2) when traffic increase, the signal strengh periodicly decrease and
reassociation with AP occurs.
Changing ipw2200's rate (in my case to 1M) just reduce a little bit the problem
(by reducing the number of "DUP !").
------- Comment #6 From 2005-06-22 04:29:33 -------
(In reply to comment #5)
> Symptoms :
> 1) duplicate Packets, packet loss, fluctuating ping times

Yours is a different bug with this one. This bug says ipw2200 card receives its
own packets. The bug you reported will be fix in the 1.0.5 (coming soon).
------- Comment #7 From 2005-07-13 15:46:33 -------
Setting back to verified, based on Crystal's comments.