Bug 525 - compile problem with '__FUNCTION__,' on older gcc
: compile problem with '__FUNCTION__,' on older gcc
Status: VERIFIED FIXED
: IPW2200
Install
: 0.19
: All Debian
: P2 minor
Assigned To:
:
:
:
:
:
  Show dependency treegraph
 
Reported: 2005-01-04 09:19 by
Modified: 2005-10-05 15:03 (History)


Attachments
Somewhat hackish way to avoid the problem (1.23 KB, patch)
2005-01-04 09:19, Dave Hansen
Details | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2005-01-04 09:19:04
I'm getting compile errors:

/home/dave/temp/ipw2200-0.19/ipw2200.c: In function `ipw_get_ordinal':
/home/dave/temp/ipw2200-0.19/ipw2200.c:484: parse error before `)'
/home/dave/temp/ipw2200-0.19/ipw2200.c:490: parse error before `)'
/home/dave/temp/ipw2200-0.19/ipw2200.c:542: parse error before `)'
/home/dave/temp/ipw2200-0.19/ipw2200.c:572: parse error before `)'
/home/dave/temp/ipw2200-0.19/ipw2200.c:607: parse error before `)'
/home/dave/temp/ipw2200-0.19/ipw2200.c: In function `ipw_radio_kill_sw':
/home/dave/temp/ipw2200-0.19/ipw2200.c:939: parse error before `)'
...

Caused by this line:

        in_interrupt() ? 'I' : 'U', __FUNCTION__, ## args); } while (0)

Adding a space after __FUNCTION__ and before the ',' seems to fix/hack
around it.  It's probably a gcc bug caused by my old (but currently
supported for building the kernel) compiler.

$ gcc -v
Reading specs from /usr/lib/gcc-lib/i386-linux/2.95.4/specs
gcc version 2.95.4 20011002 (Debian prerelease)

It's a simple enough workaround, so I'd appreciate if you could include
it.
------- Comment #1 From 2005-01-04 09:19:46 -------
Created an attachment (id=214) [details]
Somewhat hackish way to avoid the problem
------- Comment #2 From 2005-01-06 08:59:46 -------
Patch applied for 0.20
------- Comment #3 From 2005-01-18 14:17:55 -------
Yes, the patch fixed my previous problem.  But, I'm getting a few different
compile errors now.  I'll open a new bug.